Change assertion to warning when passing past_key_value to T5 encoder #16153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
patil-suraj
reviewed
Mar 15, 2022
Comment on lines
+650
to
+651
| if not self.is_decoder: | ||
| logger.warning("`past_key_values` is passed to the encoder. Please make sure this is intended.") |
There was a problem hiding this comment.
We should raise an ValueError here because past_key_values is not a valid input for the encoder and should not be passed.
There was a problem hiding this comment.
Please see the discussion in #15591
|
I'm fine with this change |
patrickvonplaten
approved these changes
Mar 17, 2022
|
Thanks. I don't think I can merge -- please merge whenever makes sense. |
|
@patil-suraj feel free to merge if ok for you |
patil-suraj
approved these changes
Mar 18, 2022
FrancescoSaverioZuppichini
pushed a commit
that referenced
this pull request
Mar 24, 2022
…#16153) * Change assertion to warning when passing past_key_value to T5 encoder * lint
|
hi guys, I have one question, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case. T5 encoder past_key_values #15591
documentation guidelines, and
here are tips on formatting docstrings. N/A
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.