Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to xlnet #16214

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

mowafess
Copy link
Contributor

@mowafess mowafess commented Mar 17, 2022

What does this PR do?

I added type annotations for xlnet (PT and TF) as described in [#16059]

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Rocketknight1 @patrickvonplaten @sgugger

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 17, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, no changes needed! And thanks for covering both TF and PT in a single PR.

@Rocketknight1 Rocketknight1 merged commit c6f7ea1 into huggingface:master Mar 21, 2022
FrancescoSaverioZuppichini pushed a commit that referenced this pull request Mar 24, 2022
* added type hints to xlnet PT

* added type hints to xlnet TF

* added type hints to xlnet TF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants