Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] add has_attentions as done in PyTorch side #16259

Merged
merged 1 commit into from
Mar 19, 2022
Merged

[WIP] add has_attentions as done in PyTorch side #16259

merged 1 commit into from
Mar 19, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Mar 18, 2022

What does this PR do?

My original intention is to clean up TFModelTesterMixin.test_pt_tf_model_equivalence. This is done in this first commit.
Would like to hear from @sgugger to see if it is better to apply the same change found in #15909 here.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 18, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Mar 18, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! We should be consistent between the two testers and this helps in this case.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Mar 18, 2022

So I will merge as it is, and work in a follow up PR to use has_attentions to other (TF) test methods like test_model_outputs_equivalence etc.

@ydshieh ydshieh merged commit f466936 into huggingface:master Mar 19, 2022
@ydshieh ydshieh deleted the tiny_cleanup_pt_tf_equivalence_test_in_tf branch March 19, 2022 10:44
@ydshieh ydshieh mentioned this pull request Mar 21, 2022
Merged
FrancescoSaverioZuppichini pushed a commit that referenced this pull request Mar 24, 2022
@ydshieh @FrancescoSaverioZuppichini
Add has_attentions to TFModelTesterMixin as done on PyTorch side (#16259
aac9d99 
)

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydshieh @HuggingFaceDocBuilderDev @sgugger