Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints for ConvBert model #16377

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

zehua99
Copy link
Contributor

@zehua99 zehua99 commented Mar 23, 2022

What does this PR do?

Adding type hints for ConvBert’s PyTorch and TensorFlow flavored models as requested in #16059.

@Rocketknight1

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 23, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! There was one missing output type, but other than that this is perfect.

src/transformers/models/convbert/modeling_convbert.py Outdated Show resolved Hide resolved
@Rocketknight1 Rocketknight1 merged commit 41bfc1e into huggingface:main Mar 24, 2022
@zehua99 zehua99 deleted the add-type-def-for-convbert branch March 24, 2022 17:11
@F02934 F02934 mentioned this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants