Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 [i18n-KO] Translated custom_models.mdx to Korean #22534

Merged
merged 1 commit into from
Apr 17, 2023
Merged

🌐 [i18n-KO] Translated custom_models.mdx to Korean #22534

merged 1 commit into from
Apr 17, 2023

Conversation

HanNayeoniee
Copy link
Contributor

@HanNayeoniee HanNayeoniee commented Apr 3, 2023 •
edited

What does this PR do?

Translated the custom_models.mdx file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Team PseudoLab, may you please review this PR?
@0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

May you please review this PR?
@sgugger, @ArthurZucker, @eunseojo

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 3, 2023 •
edited

The documentation is not available anymore as the PR was closed or merged.

@wonhyeongseo wonhyeongseo mentioned this pull request Apr 4, 2023
Open
84 tasks
HusseinMansourMohd
HusseinMansourMohd reviewed Apr 5, 2023
View reviewed changes
Copy link

@HusseinMansourMohd HusseinMansourMohd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review 1

HusseinMansourMohd
HusseinMansourMohd reviewed Apr 5, 2023
View reviewed changes
Copy link

@HusseinMansourMohd HusseinMansourMohd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review pass

@gabrielwithappy
Copy link
Contributor

I think we should discuss whether to translate configuration to 구성.
Since the configuration is the name of the class, I think it will be misunderstood when translated into Korean to understand that it is a class.

configuration이 class의 이름이기 때문에 한국어로 번역 시 class임을 이해하지 못하도록 오해할 것 같습니다.

0525hhgus
0525hhgus reviewed Apr 9, 2023
View reviewed changes
Copy link
Contributor

@0525hhgus 0525hhgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the good translation!
Please check the review below 😄

docs/source/ko/custom_models.mdx Outdated Show resolved Hide resolved
@HanNayeoniee
Copy link
Contributor Author

I think we should discuss whether to translate configuration to 구성. Since the configuration is the name of the class, I think it will be misunderstood when translated into Korean to understand that it is a class.

configuration이 class의 이름이기 때문에 한국어로 번역 시 class임을 이해하지 못하도록 오해할 것 같습니다.

저도 놓친 부분이네요. 클래스를 의미하는 부분은 configuration로, 클래스를 의미하지 않는 부분(본문에서 config라고 적힌 경우)은 구성으로 번역하는걸 검토해보겠습니다.

sim-so
sim-so suggested changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@sim-so sim-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다!
리뷰하고 몇 가지 의견을 붙여 보냅니다. 😄

docs/source/ko/custom_models.mdx Outdated Show resolved Hide resolved
docs/source/ko/custom_models.mdx Outdated Show resolved Hide resolved
docs/source/ko/custom_models.mdx Outdated Show resolved Hide resolved
docs/source/ko/custom_models.mdx Outdated Show resolved Hide resolved
docs/source/ko/custom_models.mdx Outdated Show resolved Hide resolved
docs/source/ko/custom_models.mdx Outdated Show resolved Hide resolved
docs/source/ko/custom_models.mdx Outdated Show resolved Hide resolved
docs/source/ko/custom_models.mdx Outdated Show resolved Hide resolved
@HanNayeoniee
Copy link
Contributor Author

May you please review this PR?
@sgugger, @ArthurZucker, @eunseojo

@HanNayeoniee HanNayeoniee changed the title [WIP]🌐 [i18n-KO] Translated custom_models.mdx to Korean 🌐 [i18n-KO] Translated custom_models.mdx to Korean Apr 16, 2023
@HanNayeoniee @wonhyeongseo
@gabrielwithappy @jungnerd
docs: ko: translated custom_models.mdx
c288ff1 
Co-Authored-By: Wonhyeong Seo <wonhseo@kakao.com>
Co-Authored-By: Gabriel Yang <gabrielwithhappy@gmail.com>
Co-Authored-By: Jungnerd <46880056+jungnerd@users.noreply.github.com>
sgugger
sgugger approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@sgugger sgugger merged commit 18c8948 into huggingface:main Apr 17, 2023
2 checks passed
@HanNayeoniee HanNayeoniee deleted the ko-sharing-custom-models branch April 24, 2023 15:20
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
@HanNayeoniee @wonhyeongseo
@gabrielwithappy @jungnerd @novice03
🌐 [i18n-KO] Translated custom_models.mdx to Korean (huggingface#22534)
7287b0d 
docs: ko: translated `custom_models.mdx`

Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
Co-authored-by: Gabriel Yang <gabrielwithhappy@gmail.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonhyeongseo wonhyeongseo wonhyeongseo left review comments

@HusseinMansourMohd HusseinMansourMohd HusseinMansourMohd left review comments

@0525hhgus 0525hhgus 0525hhgus left review comments

@kihoon71 kihoon71 kihoon71 left review comments

@sim-so sim-so sim-so requested changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@HanNayeoniee @HuggingFaceDocBuilderDev @gabrielwithappy @wonhyeongseo @sgugger @HusseinMansourMohd @0525hhgus @kihoon71 @sim-so