Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be nice to TF #24076

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Be nice to TF #24076

merged 2 commits into from
Jun 7, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jun 7, 2023

What does this PR do?

... and to @Rocketknight1

To be serious: to avoid OOM issue introduced in #23234. Note torch_job use pytest_num_workers=3.

See this comment.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 7, 2023

The documentation is not available anymore as the PR was closed or merged.

@Rocketknight1
Copy link
Member

LGTM! If the torch value is 3 we could probably reduce the TF value even lower, but let's try this first.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for updating!

@ydshieh
Copy link
Collaborator Author

ydshieh commented Jun 7, 2023

7 avoids the issue, but still 96~98% memory. Change it to 6 and will merge.

@ydshieh ydshieh merged commit 092c14c into main Jun 7, 2023
@ydshieh ydshieh deleted the p7 branch June 7, 2023 14:18
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants