Guard XLA version imports #30167
Merged
Guard XLA version imports #30167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeounoh
reviewed
Apr 10, 2024
| @@ -664,6 +671,8 @@ def __init__( | |||
|
|
|||
| self.is_fsdp_xla_v2_enabled = args.fsdp_config.get("xla_fsdp_v2", False) | |||
| if self.is_fsdp_xla_v2_enabled: | |||
| if not IS_XLA_FSDPV2_POST_2_2: | |||
| raise ValueError("FSDPv2 requires `torch_xla` 2.2 or higher.") | |||
There was a problem hiding this comment.
Thanks for the quick look @yeounoh :)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
pushed a commit
that referenced
this pull request
Apr 22, 2024
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As reported by @michaelbenayoun, spmd and runtime imports are only available after torch_xla 2.2.
This PR adds some guards around those imports
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@amyeroberts