Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolate pos encode vitmae #30657

Closed

Conversation

bhuvanmdev
Copy link
Contributor

@bhuvanmdev bhuvanmdev commented May 5, 2024

What does this PR do?

Adds interpolation capabilities for the tf and pytorch versions of vit_mae along with the test cases.

Addresses #30579 (vit_mae)

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested.

@amyeroberts

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Overall looking good - just some small nits and implementation comments

src/transformers/models/vit_mae/modeling_vit_mae.py Outdated Show resolved Hide resolved
src/transformers/models/vit_mae/modeling_vit_mae.py Outdated Show resolved Hide resolved
src/transformers/models/vit_mae/modeling_vit_mae.py Outdated Show resolved Hide resolved
src/transformers/models/vit_mae/modeling_vit_mae.py Outdated Show resolved Hide resolved
src/transformers/models/vit_mae/modeling_vit_mae.py Outdated Show resolved Hide resolved
src/transformers/models/vit_mae/modeling_vit_mae.py Outdated Show resolved Hide resolved
src/transformers/models/vit_mae/modeling_vit_mae.py Outdated Show resolved Hide resolved
src/transformers/models/vit_mae/modeling_vit_mae.py Outdated Show resolved Hide resolved
src/transformers/models/vit_mae/modeling_vit_mae.py Outdated Show resolved Hide resolved
src/transformers/models/vit_mae/modeling_vit_mae.py Outdated Show resolved Hide resolved
@bhuvanmdev bhuvanmdev closed this May 8, 2024
@bhuvanmdev bhuvanmdev deleted the interpolate-pos-encode-vitmae branch May 8, 2024 12:09
@bhuvanmdev bhuvanmdev restored the interpolate-pos-encode-vitmae branch May 8, 2024 12:23
@bhuvanmdev bhuvanmdev reopened this May 8, 2024
@bhuvanmdev
Copy link
Contributor Author

bhuvanmdev commented May 8, 2024

I'm really Sorry, I got confused with one of my older branch and ended up polluting the PR. Will clean up the mess. Sorry for increasing your workload :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants