Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model summary #4789

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Add model summary #4789

merged 2 commits into from
Jun 5, 2020

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Jun 5, 2020

This PR adds a high-level summary of all the models in the documentation.

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #4789 into master will increase coverage by 0.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4789      +/-   ##
==========================================
+ Coverage   76.06%   76.46%   +0.40%     
==========================================
  Files         128      128              
  Lines       21498    21498              
==========================================
+ Hits        16353    16439      +86     
+ Misses       5145     5059      -86     
Impacted Files Coverage Δ
src/transformers/file_utils.py 73.85% <0.00%> (-0.42%) ⬇️
src/transformers/modeling_tf_utils.py 87.20% <0.00%> (-0.16%) ⬇️
src/transformers/data/processors/squad.py 56.68% <0.00%> (+28.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9109f2...0e3789d. Read the comment docs.

@patrickvonplaten
Copy link
Contributor

Looks great :-)

Copy link
Contributor

@sshleifer sshleifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I would add back and forth links with pretrained_models.rst

@sgugger
Copy link
Collaborator Author

sgugger commented Jun 5, 2020

Eh, forgot to finish my sentence linking to the pretrained models doc page at the beginning. No sure if I can link to part of the tables however, does restructured text can support that?

@sshleifer
Copy link
Contributor

I doubt it. One link is OK I think

@sgugger sgugger merged commit fa661ce into huggingface:master Jun 5, 2020
@sgugger sgugger deleted the model_summary branch June 5, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants