parse arguments from dict #4869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4869 +/- ##
==========================================
+ Coverage 76.55% 76.57% +0.01%
==========================================
Files 128 128
Lines 21502 21510 +8
==========================================
+ Hits 16461 16471 +10
+ Misses 5041 5039 -2
Continue to review full report at Codecov.
|
LysandreJik
approved these changes
Jun 9, 2020
julien-c
reviewed
Jun 10, 2020
| @@ -152,6 +152,20 @@ def test_with_optional(self): | |||
| args = parser.parse_args("--foo 12 --bar 3.14 --baz 42 --ces a b c --des 1 2 3".split()) | |||
| self.assertEqual(args, Namespace(foo=12, bar=3.14, baz="42", ces=["a", "b", "c"], des=[1, 2, 3])) | |||
|
|
|||
| def test_parse_dict(self): | |||
| parser = HfArgumentParser(BasicExample) | |||
There was a problem hiding this comment.
This is nit-picking, but the unit test would be more realistic if it took more than one dataclass, like ((BasicExample, AnotherExample))
|
Hi @LysandreJik , what do you think about this ? If it's not really necessary, I will close the PR. Thanks! |
LysandreJik
approved these changes
Jul 31, 2020
Mehrad0711
pushed a commit
to Mehrad0711/transformers
that referenced
this pull request
Aug 3, 2020
* add parse_dict to parse arguments from dict * add unit test for parse_dict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds parse_dict method to HfArgumentParser to allow parsing arguments from dict
@julien-c
As suggested by you here #4791, I've added a simple unit test to check if the dataclass returned by
parse_dictis same as manually initialised one.