Don't init TPU device twice #4916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4916 +/- ##
=======================================
Coverage 77.12% 77.13%
=======================================
Files 128 128
Lines 21650 21649 -1
=======================================
+ Hits 16698 16699 +1
+ Misses 4952 4950 -2
Continue to review full report at Codecov.
|
|
Oh, my bad! Not sure why I left it there |
patrickvonplaten
approved these changes
Jun 10, 2020
|
No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4893
The TPU device was initialized twice when using a the
xla_spawn.pyscript. Removing this initialization solves the issue.@patrickvonplaten, is this necessary for the benchmarking script?