Test XLA examples #5583
Merged
Test XLA examples #5583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshleifer
approved these changes
Jul 7, 2020
.circleci/config.yml
Outdated
| @@ -73,7 +73,7 @@ jobs: | |||
| - checkout | |||
| - run: sudo pip install .[sklearn,torch,testing] | |||
| - run: sudo pip install -r examples/requirements.txt | |||
| - run: python -m pytest -n 8 --dist=loadfile -s ./examples/ | tee output.txt | |||
| - run: python -m pytest -n 8 --dist=loadfile -s ./examples/ --ignore=examples/test_xla_examples.py | tee output.txt | |||
There was a problem hiding this comment.
you could also make a require_xla decorator.
| # Assert that the model trains | ||
| self.assertGreaterEqual(value, 0.70) | ||
|
|
||
| # Assert that the script takes less than 100 seconds to make sure it doesn't hang. |
There was a problem hiding this comment.
(nit) You can do this with pytimeout
Codecov Report
@@ Coverage Diff @@
## master #5583 +/- ##
==========================================
+ Coverage 76.31% 77.83% +1.52%
==========================================
Files 145 145
Lines 25049 25053 +4
==========================================
+ Hits 19116 19500 +384
+ Misses 5933 5553 -380
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a script to test examples on XLA.