Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] github actions CI by reverting #5138 #5686

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

sshleifer
Copy link
Contributor

@sshleifer sshleifer commented Jul 11, 2020

On github actions, even when the tests fail the job is green, presumably because of my artifacts change( #5318 ).
I am not clear on why this happens, but have verified that this does not happen on CircleCI.
In the screenshot below, there is a green check mark, but also 2 tests have failed:

image

@sshleifer sshleifer changed the title [Fix] revert github actions output.txt [Fix] github actions CI by reverting #5138 Jul 11, 2020
@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #5686 into master will increase coverage by 1.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5686      +/-   ##
==========================================
+ Coverage   77.01%   78.11%   +1.10%     
==========================================
  Files         128      146      +18     
  Lines       21615    25983    +4368     
==========================================
+ Hits        16646    20297    +3651     
- Misses       4969     5686     +717     
Impacted Files Coverage Δ
src/transformers/__init__.py 99.24% <ø> (+0.11%) ⬆️
src/transformers/benchmark/benchmark.py 74.01% <ø> (+5.16%) ⬆️
src/transformers/benchmark/benchmark_args.py 86.04% <ø> (+0.68%) ⬆️
src/transformers/benchmark/benchmark_args_tf.py 87.50% <ø> (ø)
src/transformers/benchmark/benchmark_args_utils.py 89.13% <ø> (-7.75%) ⬇️
src/transformers/benchmark/benchmark_tf.py 61.53% <ø> (ø)
src/transformers/benchmark/benchmark_utils.py 69.50% <ø> (-3.60%) ⬇️
src/transformers/configuration_albert.py 100.00% <ø> (ø)
src/transformers/configuration_auto.py 93.18% <ø> (+0.32%) ⬆️
src/transformers/configuration_bart.py 93.75% <ø> (+0.41%) ⬆️
... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc31a72...7c84917. Read the comment docs.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad it did not work.

@patrickvonplaten
Copy link
Contributor

Did you try to use 2>&1 | tee output.txt instead of just | tee output.txt ? Don't know at all if this would work instead, but might be worth trying giving the first answer in this stack overflow: https://stackoverflow.com/questions/418896/how-to-redirect-output-to-a-file-and-stdout

@sshleifer
Copy link
Contributor Author

@patrickvonplaten I think that will just make the logfile include stderr, and the job might still succeed for the same reason it is succeeding now. Do you know how to test locally?

@sshleifer
Copy link
Contributor Author

Gunna try this for the 7pm run tonight and then we can be more aggressive later.

@sshleifer sshleifer merged commit c3c61ea into huggingface:master Jul 13, 2020
@sshleifer sshleifer deleted the fix-actions branch July 13, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants