Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc improvements #5688

Merged
merged 1 commit into from
Jul 13, 2020
Merged

doc improvements #5688

merged 1 commit into from
Jul 13, 2020

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Jul 11, 2020

a few documentation improvements - one variable name consistency rename, and the rest are small tweaks with one clarification.

@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #5688 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5688      +/-   ##
==========================================
- Coverage   77.01%   76.76%   -0.25%     
==========================================
  Files         128      146      +18     
  Lines       21615    25983    +4368     
==========================================
+ Hits        16646    19945    +3299     
- Misses       4969     6038    +1069     
Impacted Files Coverage Δ
src/transformers/__init__.py 99.24% <ø> (+0.11%) ⬆️
src/transformers/benchmark/benchmark.py 74.01% <ø> (+5.16%) ⬆️
src/transformers/benchmark/benchmark_args.py 86.04% <ø> (+0.68%) ⬆️
src/transformers/benchmark/benchmark_args_tf.py 87.50% <ø> (ø)
src/transformers/benchmark/benchmark_args_utils.py 89.13% <ø> (-7.75%) ⬇️
src/transformers/benchmark/benchmark_tf.py 61.53% <ø> (ø)
src/transformers/benchmark/benchmark_utils.py 69.50% <ø> (-3.60%) ⬇️
src/transformers/configuration_albert.py 100.00% <ø> (ø)
src/transformers/configuration_auto.py 93.18% <ø> (+0.32%) ⬆️
src/transformers/configuration_bart.py 93.75% <ø> (+0.41%) ⬆️
... and 109 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc31a72...2242bb2. Read the comment docs.

Copy link
Contributor

@JetRunner JetRunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@JetRunner JetRunner merged commit 0a19a49 into huggingface:master Jul 13, 2020
@stas00 stas00 deleted the doc1 branch July 13, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants