Make the order of additional special tokens deterministic #5704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5704 +/- ##
==========================================
- Coverage 78.26% 77.32% -0.95%
==========================================
Files 146 146
Lines 25998 25998
==========================================
- Hits 20348 20102 -246
- Misses 5650 5896 +246
Continue to review full report at Codecov.
|
JetRunner
approved these changes
Jul 13, 2020
LysandreJik
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
SpecialTokensMixin.all_special_tokens_extended, deduplication is performed byall_toks = list(set(all_toks)). However, this will change the ordering of additional special tokens, and the order depends on the hash seed of set data structure. This will result in non-deterministic id of additional special tokens added toAutoTokenizer.from_pretrainedmethod. Therefore, I changed this problematic line toall_toks = list(OrderedDict.fromkeys(all_toks)). This line will deduplicateall_tokswhile still keeping the original ordering.