[pack_dataset] don't sort before packing, only pack train #5954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
approved these changes
Jul 22, 2020
examples/seq2seq/minify_dataset.py
Outdated
| from pathlib import Path | ||
| import fire | ||
|
|
||
| def minify(src_dir: Path, dest_dir: Path, n: int): |
There was a problem hiding this comment.
Nit: type-hint should be Union[Path, str] since you wrap src_dir and dest_dir in a Path after.
Codecov Report
@@ Coverage Diff @@
## master #5954 +/- ##
==========================================
+ Coverage 78.52% 78.56% +0.03%
==========================================
Files 146 146
Lines 26314 26314
==========================================
+ Hits 20664 20674 +10
+ Misses 5650 5640 -10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is better than sorting.
But for best metrics, don't pack.