[docs] Add integration test example to copy pasta template #5961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshleifer
commented
Jul 22, 2020
| @@ -268,7 +270,33 @@ def test_for_token_classification(self): | |||
| self.model_tester.create_and_check_xxx_for_token_classification(*config_and_inputs) | |||
|
|
|||
| @slow | |||
| def test_model_from_pretrained(self): | |||
There was a problem hiding this comment.
I am not a fan of this thing.
It wastes time and money and is very very shallow.
sshleifer
commented
Jul 22, 2020
sshleifer
commented
Jul 22, 2020
| self.attention_probs_dropout_prob = attention_probs_dropout_prob | ||
| self.max_position_embeddings = max_position_embeddings | ||
| self.type_vocab_size = type_vocab_size | ||
| self.type_sequence_label_size = type_sequence_label_size |
There was a problem hiding this comment.
would love to not have this take any kwargs./
sgugger
approved these changes
Jul 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #5961 +/- ##
==========================================
- Coverage 78.50% 77.27% -1.23%
==========================================
Files 146 146
Lines 26214 26218 +4
==========================================
- Hits 20578 20259 -319
- Misses 5636 5959 +323
Continue to review full report at Codecov.
|
sshleifer
commented
Jul 22, 2020
| @@ -55,4 +55,5 @@ jobs: | |||
| USE_CUDA: yes | |||
| run: | | |||
| source .env/bin/activate | |||
| pip install -r examples/requirements.txt | |||
sshleifer
commented
Jul 22, 2020
| "loss": loss, | ||
| "logits": logits, | ||
| } | ||
| self.parent.assertListEqual(list(result["logits"].size()), [self.batch_size, self.num_labels]) |
julien-c
reviewed
Jul 22, 2020
julien-c
approved these changes
Jul 22, 2020
| @@ -55,4 +55,5 @@ jobs: | |||
| USE_CUDA: yes | |||
| run: | | |||
| source .env/bin/activate | |||
| pip install -r examples/requirements.txt | |||
sshleifer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encourage testing practices that have been encouraged since last update, namely:
My code is probably broken because this thing isn't tested!
Add:
"""
Try to make this test take a string and check that a resultant string == desired_result using your tokenizers encode and decode functions
""