Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing docker arg for TPU CI. #6393

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Add missing docker arg for TPU CI. #6393

merged 1 commit into from
Aug 11, 2020

Conversation

zcain117
Copy link
Contributor

Fixes "docker build" requires exactly 1 argument. for the path where $CIRCLE_PR_NUMBER is unset.

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #6393 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6393      +/-   ##
==========================================
- Coverage   79.40%   79.16%   -0.24%     
==========================================
  Files         148      148              
  Lines       27200    27200              
==========================================
- Hits        21598    21533      -65     
- Misses       5602     5667      +65     
Impacted Files Coverage Δ
src/transformers/tokenization_xlm.py 16.26% <0.00%> (-66.67%) ⬇️
src/transformers/modeling_tf_flaubert.py 24.53% <0.00%> (-63.20%) ⬇️
src/transformers/tokenization_openai.py 71.21% <0.00%> (-11.37%) ⬇️
src/transformers/tokenization_transfo_xl.py 33.56% <0.00%> (-5.17%) ⬇️
src/transformers/tokenization_utils.py 90.40% <0.00%> (+0.40%) ⬆️
src/transformers/tokenization_bert.py 91.51% <0.00%> (+0.44%) ⬆️
src/transformers/tokenization_utils_fast.py 94.28% <0.00%> (+2.14%) ⬆️
src/transformers/generation_tf_utils.py 86.46% <0.00%> (+7.26%) ⬆️
src/transformers/tokenization_utils_base.py 93.84% <0.00%> (+7.41%) ⬆️
src/transformers/tokenization_roberta.py 98.63% <0.00%> (+21.91%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06bc347...3d1b87b. Read the comment docs.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM

@LysandreJik LysandreJik merged commit f65ac1f into huggingface:master Aug 11, 2020
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants