Support additional dictionaries for BERT Japanese tokenizers #6515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @JetRunner and @polm. I've fixed the test-related issues and it should be OK now. |
Zigur
pushed a commit
to Zigur/transformers
that referenced
this pull request
Oct 26, 2020
…face#6515) * Update BERT Japanese tokenizers * Update CircleCI config to download unidic * Specify to use the latest dictionary packages
fabiocapsouza
added a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
…uggingface#6515)" This reverts commit 74700e9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support additional dictionaries for BERT Japanese tokenizers.
Specifically, we add support for
unidic_liteandunidicdictionaries.Both dictionaries are pip-installable like
ipadicand compatible with thefugashipackage introduced in #6086 by @polm.(We are going to release newly pre-trained BERT models using these dictionaries as well.)