TFTrainer dataset doc & fix evaluation bug #6618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
reviewed
Aug 20, 2020
| @@ -38,7 +38,11 @@ class TFTrainer: | |||
| args (:class:`~transformers.TFTrainingArguments`): | |||
| The arguments to tweak training. | |||
| train_dataset (:class:`~tf.data.Dataset`, `optional`): | |||
| The dataset to use for training. | |||
| The dataset to use for training. The dataset should yield tuples of ``(features, labels)`` where | |||
There was a problem hiding this comment.
I imagine it's the same for eval_dataset, or the datasets passed along to evaluate or predict, so I'd copy this docstrings over there too.
There was a problem hiding this comment.
Oh yeah, I think they do expect the same format. Added.
sgugger
approved these changes
Aug 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #6618 +/- ##
==========================================
- Coverage 79.79% 78.86% -0.94%
==========================================
Files 156 156
Lines 28213 28213
==========================================
- Hits 22513 22250 -263
- Misses 5700 5963 +263
Continue to review full report at Codecov.
|
Zigur
pushed a commit
to Zigur/transformers
that referenced
this pull request
Oct 26, 2020
* TFTrainer dataset doc & fix evaluation bug discussed in huggingface#6551 * add docstring to test/eval datasets
fabiocapsouza
pushed a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
* TFTrainer dataset doc & fix evaluation bug discussed in huggingface#6551 * add docstring to test/eval datasets
fabiocapsouza
added a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
This reverts commit 47c523b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discussed in #6551