Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wip/hughsie/query bound tokenize #145

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Wip/hughsie/query bound tokenize #145

merged 2 commits into from
Aug 16, 2023

Conversation

hughsie
Copy link
Owner

@hughsie hughsie commented Aug 15, 2023

No description provided.

@hughsie hughsie requested a review from ximion August 15, 2023 19:46
@hughsie hughsie mentioned this pull request Aug 15, 2023
Closed
ximion
ximion approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@ximion ximion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and makes perfect sense - just maybe drop the works/fails from my original comment strings before merging.

Thank you for looking into this!

src/xb-self-test.c Outdated Show resolved Hide resolved
src/xb-self-test.c Outdated Show resolved Hide resolved
@hughsie hughsie force-pushed the wip/hughsie/query-bound-tokenize branch from a53bc26 to 95a349b Compare August 16, 2023 08:14
@hughsie hughsie merged commit d77f42f into main Aug 16, 2023
2 checks passed
@hughsie hughsie deleted the wip/hughsie/query-bound-tokenize branch August 16, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ximion ximion ximion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hughsie @ximion