Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trivial: Abort the compile when MSVC is detected #151

Merged
merged 1 commit into from
Sep 17, 2023
Merged

trivial: Abort the compile when MSVC is detected #151

merged 1 commit into from
Sep 17, 2023

Conversation

hughsie
Copy link
Owner

@hughsie hughsie commented Sep 17, 2023

No description provided.

@hughsie hughsie requested a review from ximion September 17, 2023 17:14
@hughsie hughsie self-assigned this Sep 17, 2023
@ximion
Copy link
Collaborator

ximion commented Sep 17, 2023

That's a good idea! I should add something similar to my projects as well!
If MSVC ever does add support, this would need to become a versioned check of course - but I assume Microsoft would rather switch to Clang completely than to expend its C support...

@hughsie hughsie merged commit dad4da5 into main Sep 17, 2023
2 checks passed
@hughsie hughsie deleted the wip/hughsie/msvc branch September 17, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ximion ximion ximion approved these changes

Assignees

@hughsie hughsie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hughsie @ximion