Check res.headersSent before calling res.setHeader() in bail() #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks @robert-chiniquy! :D |
hughsk
added a commit
that referenced
this pull request
Oct 19, 2014
…in-bail Check res.headersSent before calling res.setHeader() in bail()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed sometimes
bail()would be called after headers had already been written on the response. In this case, instead of writing the error back on the response, it throws and kills the server process.This fix just doesn't set
text/plainif headers have already been written, so the error is written to the request and the server can serve subsequent requests.