Allow Redirect Requests

[thiagotalma]

Use Case: The user fills out a form that is posted to the webhook and then he is redirected to the success page.

PS: I'm not a Ruby programmer, you know, right? Please have patience with my code 😉

[dsander]

I think that is a good addition! Can you add some specs for the redirect case to the web_request_controller_spec and for the validation of the agent?

[thiagotalma]

@dsander I do not know how to write the redirect tests. Can you help me please?

[thiagotalma]

@cantino
Feel free to start a new PR with an attempt at this, and I can help suggest how to do it there.

I did it! :)

[dsander]

@thiagotalma I think that test should work:

diff --git a/spec/controllers/web_requests_controller_spec.rb b/spec/controllers/web_requests_controller_spec.rb
index addb912..0c64750 100644
--- a/spec/controllers/web_requests_controller_spec.rb
+++ b/spec/controllers/web_requests_controller_spec.rb
@@ -10,7 +10,7 @@ describe WebRequestsController do
         memory[:web_request_values] = params
         memory[:web_request_format] = format
         memory[:web_request_method] = method
-        ["success", 200, memory['content_type']]
+        ["success", (options[:status] || 200).to_i, memory['content_type']]
       else
         ["failure", 404]
       end
@@ -85,6 +85,13 @@ describe WebRequestsController do
     expect(response.headers['Content-Type']).to eq('application/json; charset=utf-8')
   end

+  it 'should redirect correctly' do
+    @agent.options['status'] = 302
+    @agent.save
+    post :handle_request, params: {:user_id => users(:bob).to_param, :agent_id => @agent.id, :secret => "my_secret"}, format: :json
+    expect(response).to redirect_to('success')
+  end
+
   it "should fail on incorrect users" do
     post :handle_request, params: {:user_id => users(:jane).to_param, :agent_id => @agent.id, :secret => "my_secret", :no => "go"}
     expect(response).to be_missing

[thiagotalma]

@dsander done!

Thanks!

[dsander]

Thanks looks good to me, looks like the WebhookAgent could use some additional specs but that does not need to happen in this PR.

[cantino]

Maybe options['code'].to_s in case they used an int?

[cantino]

Does agent.trigger_web_request(request) always return status as an integer?

[thiagotalma]

@cantino fixed!

[cantino]

Worked for me, thanks @thiagotalma, this is a handy contribution.