Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught reference error: adjustSkillCardsHeight() is not defined #441

Closed
3 tasks done
Nirzak opened this issue Oct 20, 2021 · 6 comments · Fixed by #488
Closed
3 tasks done

Uncaught reference error: adjustSkillCardsHeight() is not defined #441

Nirzak opened this issue Oct 20, 2021 · 6 comments · Fixed by #488

Comments

@Nirzak
Copy link
Contributor

Nirzak commented Oct 20, 2021

Expected Behavior

There should be a declaration for this function in home.js file.

Current Behavior

But no function titled "adjustSkillCardsheight()" is defined. This might also cause other errors such as skill cards will not resize when reduce to mobile screen and etc.

Possible Solution

Either this function should be defined or be deleted if is not useful.

Steps to Reproduce

  1. Open https://hugo-toha.github.io
  2. Press ctrl + shift + J to open the developer menu.
  3. Click on the console tab

Screenshots

Screenshot (3793)

Browsers Affected

  • Chrome
  • Firefox
  • Edge
@hossainemruz hossainemruz added bug Something isn't working and removed bug Something isn't working labels Oct 28, 2021
@pboling
Copy link

pboling commented Nov 1, 2021

Having this same error. Not sure when but my toha themed site is now completely broken, and although I don't think it is related, this is the only error.

@hossainemruz
Copy link
Member

@pboling It seems your website is looking for the CSS files in https://railsbling.com/assets/css/layouts/ directory where they are available at https://railsbling.com/css/layouts/ directory. I am not sure why.

@Nirzak
Copy link
Contributor Author

Nirzak commented Nov 1, 2021

Having this same error. Not sure when but my toha themed site is now completely broken, and although I don't think it is related, this is the only error.

I think you should update to the latest toha theme and also check the baseURL of your config.yaml file.

@pboling
Copy link

pboling commented Nov 8, 2021

I had hard coded assets/ into the source refs... not sure why. The site is working again!

@t-muehlberger
Copy link
Contributor

I am having the same issue, what happened to the implementation of the adjustSkillCardsheight() function? Can it be removed or will this cause a Bug?

@hossainemruz
Copy link
Member

@t-muehlberger this functionality is now done by CSS. We removed the unnecessary adjustSkillCardsheight() function but forgot to remove the reference to it. Try pulling the latest main. This should be fixed in #488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants