New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use hedgedoc container hostname if default URL is not accessible #18

Merged

hugsy merged 2 commits into hugsy:master from lanjelot:hedgedoc-failover

Jan 2, 2021

Collaborator

lanjelot commented Dec 30, 2020

My humble suggestion so that ctfpad works out of the box after a simple git clone ..; docker-compose up.
Note that:

it is only if http://localhost:3000 is down that we sub it for http://hedgedoc:3000
so if HEDGEDOC_URL was changed and is not accessible, then the user will get the right error message referencing the URL they wrongly configured


          use hedgedoc container hostname if default URL is not accessible

7b66ec6

Owner

hugsy commented Dec 30, 2020

I agree with the intention, but the implementation is terrible. It'd be way more efficient to use a cached global variable for this.


          test the URL once and cache the result

552a920

hugsy merged commit 7ba3a8a into hugsy:master

lanjelot deleted the hedgedoc-failover branch

January 3, 2021 16:14

hugsy added this to the 0.1 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet