Fix gef-extras directory location #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoefler02
changed the title
|
This looks fine to me. Can you change the script to not confusingly (imo) set or not set DIR and name in the if else chain? don't get clever, just fully set the base path in that chain and use a single var in all the invocations |
Grazfather
reviewed
Apr 7, 2021
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
Co-authored-by: Grazfather <grazfather@gmail.com>
|
Yes! Thanks for the suggestion! Not sure why I didn't it that way in the first place 😊 |
|
You forgot to remove |
|
My bad! Fixed and retested with different |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better location for gef-extras
Description/Motivation/Screenshots
Moves the
~/gef-extrasfolder to~/.config/gef-extrasif it exists, or to~/.gef-extrasotherwise. This will help de-clutter the home folder. The gef installer already does this but the gef-extras installer does not.How Has This Been Tested?
I ran several tests with different
$HOMEvalues to verify that the installer still works.Checklist
devbranch, notmaster.