Fix name-break address parsing (#707) #708
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix name-break address parsing (#707)
Description/Motivation/Screenshots
see #707
My proposed solution is to move the address parsing to
NamedBreakpoint
so the original user input will be displayed when hitting the breakpoint but the location will be converted to an address and given to GDBsBreakpoint
as a string with a prefixed*
.I also added a test (which was missing previously) to check if the
name-break
command throws an exception.How Has This Been Tested?
make test
Checklist
dev
branch, notmaster
.