Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name-break address parsing (#707) #708

Merged
merged 1 commit into from
Sep 5, 2021
Merged

Conversation

theguy147
Copy link
Collaborator

Fix name-break address parsing (#707)

Description/Motivation/Screenshots

see #707

My proposed solution is to move the address parsing to NamedBreakpoint so the original user input will be displayed when hitting the breakpoint but the location will be converted to an address and given to GDBs Breakpoint as a string with a prefixed *.

I also added a test (which was missing previously) to check if the name-break command throws an exception.

How Has This Been Tested?

Architecture Yes/No Comments
x86-32 ✔️
x86-64 ✔️
ARM ✖️
AARCH64 ✖️
MIPS ✖️
POWERPC ✖️
SPARC ✖️
RISC-V ✖️
make test ✔️

Checklist

  • My PR was done against the dev branch, not master.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • My change adds tests as appropriate.
  • I have read and agree to the CONTRIBUTING document.

@Grazfather Grazfather merged commit c4a4f58 into hugsy:dev Sep 5, 2021
@theguy147 theguy147 deleted the namebreak branch September 5, 2021 06:22
@hugsy hugsy added this to the Release: next milestone Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants