Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unicorn-emulate cmd #713

Merged
merged 4 commits into from Sep 8, 2021
Merged

Fix unicorn-emulate cmd #713

merged 4 commits into from Sep 8, 2021

Conversation

theguy147
Copy link
Collaborator

@theguy147 theguy147 commented Sep 8, 2021

Fix unicorn-emulate cmd

Description/Motivation/Screenshots

This PR is part of #693 and covers the following points:

  • Fix emulating the wrong number of instructions for even numbers
  • Update docs for cmd (incl Screenshot)
  • Fix alignment of registers in output
  • Fix address parsing of cmd
  • Update test to check for failed emulations and count the number of emulated instructions

Here some before/after screenshots:

Before

image

After

image

In the future it might even be cool to print the registers in GEFs standard way (incl marking tainted registers with color) but this PR was more about fixing the broken parts of the command.

How Has This Been Tested?

Architecture Yes/No Comments
x86-32 ✔️
x86-64 ✔️
ARM ✖️
AARCH64 ✖️
MIPS ✖️
POWERPC ✖️
SPARC ✖️
RISC-V ✖️
make test ✔️

Checklist

  • My PR was done against the dev branch, not master.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • My change adds tests as appropriate.
  • I have read and agree to the CONTRIBUTING document.

@hugsy hugsy self-requested a review September 8, 2021 23:01
Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Maybe just squash before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants