Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Generators and Comprehension #771

Merged

Conversation

theguy147
Copy link
Collaborator

Refactor: Generators and Comprehension

Description/Motivation/Screenshots

This refactoring PR addresses 3 different PEPs:

How Has This Been Tested?

Architecture Yes/No Comments
x86-32 ✔️
x86-64 ✔️
ARM ✖️
AARCH64 ✖️
MIPS ✖️
POWERPC ✖️
SPARC ✖️
RISC-V ✖️
make test ✖️ test_cmd_elf_info already failed on this branch before this PR

Checklist

  • My PR was done against the gdb_8_py36_code_refactor branch, not master.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • My change adds tests as appropriate.
  • I have read and agree to the CONTRIBUTING document.

replace list comprehensions with generator expressions when possible
e.g. for better memory efficiency (see PEP 289)
@theguy147 theguy147 merged commit a7ab48e into hugsy:gdb_8_py36_code_refactor Dec 16, 2021
@theguy147 theguy147 deleted the refactor_comprehension branch December 16, 2021 11:32
@hugsy hugsy added this to the Release: next milestone Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants