Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add tests for heap bins small, large and unsorted cmd #780

Merged
merged 2 commits into from
Jan 12, 2022
Merged

tests: add tests for heap bins small, large and unsorted cmd #780

merged 2 commits into from
Jan 12, 2022

Conversation

theguy147
Copy link
Collaborator

@theguy147 theguy147 commented Jan 12, 2022 •
edited by hugsy
Loading

Add tests for heap bins small, large and unsorted cmd

Description/Motivation/Screenshots

This PR adds some missing tests for:

  • heap bins small
  • heap bins large
  • heap bins unsorted

All 3 new tests use the same binary file heap-bins.out.

How Has This Been Tested?

Architecture Yes/No Comments
x86-32 ✖️
x86-64 ✔️
ARM ✖️
AARCH64 ✖️
MIPS ✖️
POWERPC ✖️
SPARC ✖️
RISC-V ✖️
make test ✔️

Checklist

  • My PR was done against the dev branch, not master.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • My change adds tests as appropriate.
  • I have read and agree to the CONTRIBUTING document.

hugsy
hugsy approved these changes Jan 12, 2022
View reviewed changes
Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice & easy

@hugsy hugsy added this to the Release: next milestone Jan 12, 2022
Grazfather
Grazfather approved these changes Jan 12, 2022
View reviewed changes
tests/runtests.py Outdated Show resolved Hide resolved
@hugsy hugsy merged commit 2975d5f into hugsy:dev Jan 12, 2022
@theguy147 theguy147 deleted the test_heap_bins branch January 12, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grazfather Grazfather Grazfather approved these changes

@hugsy hugsy hugsy approved these changes

Assignees
No one assigned
Labels
automation/ci documentation
Projects
None yet
Milestone
Release: 2022.01
Development

Successfully merging this pull request may close these issues.
3 participants
@theguy147 @Grazfather @hugsy