Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated add_context_pane settings use #796

Merged
merged 2 commits into from Jan 18, 2022
Merged

updated add_context_pane settings use #796

merged 2 commits into from Jan 18, 2022

Conversation

mahaloz
Copy link
Contributor

@mahaloz mahaloz commented Jan 18, 2022

Update add_context_pane settings use

Description/Motivation/Screenshots

The new API for changing settings configs in GEF has broken the add_context_pane API. This is an update for that.

How Has This Been Tested?

Architecture Yes/No Comments
x86-32 ✖️
x86-64 ✔️
ARM ✖️
AARCH64 ✖️
MIPS ✖️
POWERPC ✖️
SPARC ✖️
RISC-V ✖️
make test ✖️

Checklist

  • My PR was done against the dev branch, not master.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • My change adds tests as appropriate.
  • I have read and agree to the CONTRIBUTING document.

theguy147
theguy147 approved these changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@theguy147 theguy147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Grazfather
Grazfather reviewed Jan 18, 2022
View reviewed changes
gef.py Outdated Show resolved Hide resolved
@mahaloz @Grazfather
Update gef.py
b4135a9 
Co-authored-by: Grazfather <grazfather@gmail.com>
@mahaloz mahaloz mentioned this pull request Jan 18, 2022
Merged
@Grazfather Grazfather merged commit 67fccb5 into hugsy:dev Jan 18, 2022
@hugsy hugsy added this to the Release: next milestone Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grazfather Grazfather Grazfather approved these changes

@theguy147 theguy147 theguy147 approved these changes

Assignees
No one assigned
Labels
bug confirmed
Projects
None yet
Milestone
Release: 2022.01
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mahaloz @Grazfather @theguy147 @hugsy