Fix for Cosmos-SDK 0.44

[ctrl-Felix]

After providing a quick and dirty fix last time I now found some time to take a proper approach to this and this should finally fix the compability. This pull request includes:

• Migrating the transactions to protobuf (Compiled through the protobuf compiler)
• Updating the tests
• Adding a ibc_transfer method to allow also ibc transfers
• Add the possibility to add another account which pays the transaction fee through the feegrant module
• Allow transaction broadcasting through the RPC & API as both endpoint need a slightly different payload structure

I think this should be it. All in all the biggest gain is that cosmospy will be working again.

[hukkin]

Thanks a lot! 🥳

I'll do a proper review in the upcoming days. This is just a drive-by note about the extra dependencies.

Also, if you'd be kind enough to provide the commands/actions that you executed to autogenerate the protobuf files that'd be great!

[ctrl-Felix]

Thank you very much for your quick reply 😄
I used the protobuf compiler from here with following command:
Execute in the proto folder
protoc --python-out=<absolute path to interfaces dir> file.proto

Regarding the requests. I added two commits which removes the code snipped which used the requests dependency. (The second one is because I forgot to remove the actual dependency...)

Adding requests could be useful for helper functions tho. Like a function to get the account sequence and account number which are only accessible through a api call.

[ctrl-Felix]

Sorry adding for these commits later on. I just saw two things while going through the code once again:

• The first one was that I mesed up the broadcast modes for the api and rpc call. While the rpc refers to it as method it wants bradcast_tx_sync as method. The api refers to it as mode and therefore wants it as BROADCAST_MODE_SYNC
• Second one was that I was using protoc 3.6.1 which worked. But it's 4 years old. I took the recent version now to compile the files and the ward tests go through. However there seeom to be a coverage issue or whatever in the automated github checks. I am not yet sure what that means

[ctrl-Felix]

I went through everything now I think. I have to admit I am not 100% happy by removing the get_rpc_pushable and get_api_pushable methods, especially as this method was implemented before too.

Note: With the explanation I would say I am then 100% happy with removing it 😏

[hukkin]

Let's revert this unless there's a good reason for the change?

[hukkin]

Could you sync the proto files (and generate .py files) with what's up-to-date in https://github.com/cosmos/cosmos-sdk/tree/main/proto ?

[ctrl-Felix]

Sorry for my late reply. I will do that, but I modified some of them to remove unused dependencies. The latest proto files include already stuff that will be introduced with cosmo ssdk 0.46 or transaction types we don't need but which need other dependencies

[ctrl-Felix]

Here are the sources for the new proto files:

• https://github.com/cosmos/gogoproto/blob/master/gogoproto/gogo.proto
• https://github.com/cosmos/cosmos-sdk/blob/main/proto/cosmos/msg/v1/msg.proto
• https://github.com/cosmos/cosmos-proto/blob/main/proto/cosmos_proto/cosmos.proto

I removed the functions for MultiSig as well as other transaction types and only took MsgSend to keep the dependencies as low as possible

Changes I made to every .proto file:

• Fix the imports to the dir structure in cosmospy

Changes I made to every compiled proto file:

• fix the imports as discussed in python: use relative imports in generated modules protocolbuffers/protobuf#1491 (protoc isn't compiling them correctly)

[ctrl-Felix]

Hi @hukkin
I just wanted to ask if you had time to check the new commits