Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): add function testing guide #85

Merged
merged 2 commits into from
Mar 30, 2021
Merged

feat(docs): add function testing guide #85

merged 2 commits into from
Mar 30, 2021

Conversation

lkipke
Copy link
Contributor

@lkipke lkipke commented Mar 30, 2021

Summary

Closes #78

To view the docs locally, run npm run serve-docs.

@lkipke lkipke added enhancement New feature or request documentation labels Mar 30, 2021
@lkipke lkipke self-assigned this Mar 30, 2021
sjbarag
sjbarag approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@sjbarag sjbarag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 😄

docs/guides/README.md Outdated Show resolved Hide resolved
docs/guides/testing-functions.md Outdated Show resolved Hide resolved
alimnios72
alimnios72 approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@alimnios72 alimnios72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome, thanks for adding documentation on how to test private functions a lot of folks were asking for this. Other than Sean's suggestions, this looks good to go

@lkipke lkipke merged commit 15efd96 into hulu:main Mar 30, 2021
@lkipke lkipke deleted the add-test-scope-guide branch March 30, 2021 23:14
@lkipke lkipke mentioned this pull request Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimnios72 alimnios72 alimnios72 approved these changes

@sjbarag sjbarag sjbarag approved these changes

Assignees

@lkipke lkipke

Labels
documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarification about the test's scoping
3 participants
@lkipke @sjbarag @alimnios72