Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large images overflow viewport when height > 1024px #44

Closed
jsit opened this issue May 27, 2016 · 5 comments
Closed

Large images overflow viewport when height > 1024px #44

jsit opened this issue May 27, 2016 · 5 comments

Comments

@jsit
Copy link

jsit commented May 27, 2016

Large images overflow the viewport when the viewport height is greater than 1024px. At smaller sizes the image more appropriately is maxed at a height of 85vh.

I see no reason why the img element shouldn't have a max-height (and max-width for that matter) of 85vh/vw at all viewport sizes.

@danhumaan
Copy link
Collaborator

hi @jsit, thanks for raising this issue. We've spent some time addressing the gallery feature and implemented some updates that relate to this task and will be rolled out in v0.3.1 soon.

@danhumaan
Copy link
Collaborator

Thanks again, this is now available in the latest release.

@robzor
Copy link

robzor commented Nov 23, 2016

Sorry to thread resurrect, but after updating to the latest release, any very tall portrait images now scroll miles down the screen, making it tricky to interact with them. Can we have the max-height of 85vh back? :)

I tried reinstating it in the CSS, but it lead to some crazy jank with the fade transition where the image would stretch then ping back into size. (Or with some more tweaking, you'd get a white background area that would be visible behind the image, which would then ping back to the right size)

FWIW, Firefox, Mac OSX.

@djmtype
Copy link

djmtype commented Dec 19, 2019

I have the same issue going on in Chrome 79 as @robzor

@kcarrandale
Copy link

Having the same issue in Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants