-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RadialMeterMarker overwrites options with backgroundStyle options? #96
Comments
Thanks for pointing this out. Let me see if I can figure out what's going on. I'll try to push an update soon. |
Thanks for the fast response. I also hat issues with redrawing L.RadialBarChartMarker, after every redraw the size increases. |
Pushed a potential fix to this branch: https://github.com/humangeo/leaflet-dvf/tree/feature/chartmarkerfix Can you give this a try when you get a chance and let me know if that fixes things for you? |
@trillerpfeife Did that fix work for you? |
Thanks @sfairgrieve for the fix. I ended up making my own pie chart marker based on https://github.com/iatkin/leaflet-svgicon due to extend it in various ways. |
L.RadialMeterMarker draws a marker with given options but returns wrong options. For example:
Returns a marker with following options:
I think due to the "Add a background" implementation the option properties will be overwritten, right?
leaflet-dvf/src/leaflet.dvf.chartmarkers.js
Line 924 in 1d47d67
In issue #7 I made a fiddle to show that it will break the redraw() function
The text was updated successfully, but these errors were encountered: