Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES check_page_status cron event is never cleared #379

Closed
roborourke opened this issue Apr 23, 2021 · 0 comments · Fixed by #380
Closed

ES check_page_status cron event is never cleared #379

roborourke opened this issue Apr 23, 2021 · 0 comments · Fixed by #380
Assignees
@roborourke
Labels
bug Existing functionality isn't behaving as expected

Comments

@roborourke
Copy link
Contributor

After updating or editing an Elasticsearch config package such as synonyms or stopwords the cron task to check the status every minute is never cleared once the status is ACTIVE or some other completed / failed state.
@roborourke roborourke added the bug Existing functionality isn't behaving as expected label Apr 23, 2021
@roborourke roborourke self-assigned this Apr 23, 2021
roborourke added a commit that referenced this issue Apr 23, 2021
@roborourke
Use clear scheduled hook to remove package status check
81ed115 
The `wp_next_scheduled()` response appears to be subject to caching so for custom cron job intervals such as 1 minute in this case the next scheduled time can be too old for it to ever match the actual next event. This means the current method for clearing the scheduled task fails silently.

Using clear scheduled hook is more appropriate here because it is the arguments that are unique to the task.

Fixes #379
@roborourke roborourke mentioned this issue Apr 23, 2021
Merged
hm-backport bot pushed a commit that referenced this issue Apr 23, 2021
@roborourke
Use clear scheduled hook to remove package status check
8979ee8 
The `wp_next_scheduled()` response appears to be subject to caching so for custom cron job intervals such as 1 minute in this case the next scheduled time can be too old for it to ever match the actual next event. This means the current method for clearing the scheduled task fails silently.

Using clear scheduled hook is more appropriate here because it is the arguments that are unique to the task.

Fixes #379
hm-backport bot pushed a commit that referenced this issue Apr 23, 2021
@roborourke
Use clear scheduled hook to remove package status check
52432a8 
The `wp_next_scheduled()` response appears to be subject to caching so for custom cron job intervals such as 1 minute in this case the next scheduled time can be too old for it to ever match the actual next event. This means the current method for clearing the scheduled task fails silently.

Using clear scheduled hook is more appropriate here because it is the arguments that are unique to the task.

Fixes #379
hm-backport bot pushed a commit that referenced this issue Apr 23, 2021
@roborourke
Use clear scheduled hook to remove package status check
5adec2b 
The `wp_next_scheduled()` response appears to be subject to caching so for custom cron job intervals such as 1 minute in this case the next scheduled time can be too old for it to ever match the actual next event. This means the current method for clearing the scheduled task fails silently.

Using clear scheduled hook is more appropriate here because it is the arguments that are unique to the task.

Fixes #379
@tcrsavage tcrsavage mentioned this issue Jun 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roborourke roborourke

Labels
bug Existing functionality isn't behaving as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use clear scheduled hook to remove package status check humanmade/altis-cloud
1 participant
@roborourke