Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warnings on dynamic properties #733

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Fix deprecation warnings on dynamic properties #733

merged 1 commit into from
Apr 18, 2023

Conversation

jerico
Copy link
Contributor

@jerico jerico commented Apr 18, 2023

Addresses #729

ferschubert-hm
ferschubert-hm approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@ferschubert-hm ferschubert-hm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jerico jerico merged commit 0f0db45 into master Apr 18, 2023
@jerico jerico deleted the fix-deprecation-warnings branch April 18, 2023 22:16
@hm-backport hm-backport bot mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kovshenin kovshenin kovshenin approved these changes

@ferschubert-hm ferschubert-hm ferschubert-hm approved these changes

@wisyhambolu wisyhambolu Awaiting requested review from wisyhambolu

@mikelittle mikelittle Awaiting requested review from mikelittle

Assignees
No one assigned
Labels
backport v15-branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerico @kovshenin @ferschubert-hm