Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an exception when asking for db information but the container isn't running #618

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

johnbillion
Copy link
Member

If you run composer server db info and the container isn't running, you'll get a PHP warning about an undefined array key:

This change introduces an exception with a more helpful error message that's thrown if the database container information can't be fetched:

@johnbillion johnbillion added the bug Existing functionality isn't behaving as expected label Aug 16, 2023
@mikelittle mikelittle added this to the Altis V17 milestone Aug 17, 2023
Copy link
Contributor

@mikelittle mikelittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks John.

@mikelittle mikelittle merged commit cdf079c into master Aug 23, 2023
1 of 2 checks passed
@mikelittle mikelittle deleted the db-info branch August 23, 2023 09:23
@mikelittle mikelittle self-assigned this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality isn't behaving as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants