Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stylelint tests #286

Merged
merged 8 commits into from
Sep 16, 2022
Merged

Add stylelint tests #286

merged 8 commits into from
Sep 16, 2022

Conversation

mattheu
Copy link
Member

@mattheu mattheu commented Jul 28, 2022

Add some basic tests for styles. Follows similar setup to eslint tests. Can increase coverage in future.

@tomjn Already did a PR for updating to the latest config already: #275. Some tests could be a nice way to help test this.

@mattheu mattheu marked this pull request as draft July 28, 2022 16:10
# Conflicts:
#	packages/stylelint-config/package-lock.json
#	packages/stylelint-config/package.json
@mattheu mattheu changed the title Update stylelint Add stylelint tests Jul 28, 2022
@mattheu
Copy link
Member Author

mattheu commented Jul 28, 2022

Originally this included the update to the latest version of stylelint, but as there is already a PR for this, I figured I'd rework this to only include my tests.

@mattheu mattheu marked this pull request as ready for review July 28, 2022 16:42
package.json Outdated Show resolved Hide resolved
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch @mattheu, apologies it took a while to land this

@ntwb ntwb merged commit c3aa933 into master Sep 16, 2022
@ntwb ntwb deleted the update-stylelint branch September 16, 2022 10:53
@ntwb ntwb mentioned this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants