Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK][Agreement] Improve usability of agreement package. #910

Merged
merged 14 commits into from
Sep 28, 2023

Conversation

simulacrum6
Copy link
Contributor

@simulacrum6 simulacrum6 commented Sep 19, 2023

Description

Adds a single high level function that can be configured to call all functionalities of the agreement package in a single function call.

Summary of changes

  • Added said function.
  • Added utilty function to convert annotations in label count format.
  • Align interfaces of transformation functions.

How test the changes

pytest packages/sdk/python/human-protocol-sdk/test

Related issues

Closes #909.

Operational checklist

  • All new functionality is covered by tests
  • Any related documentation has been changed or added

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
escrow-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 1:24pm
faucet-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 1:24pm
fortune-exchange-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 1:24pm
fortune-exchange-oracle-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 1:24pm
fortune-job-launcher-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 1:24pm
fortune-job-launcher-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 1:24pm
fortune-recording-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 1:24pm
fortune-reputation-oracle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 1:24pm
human-protocol-typescript-sdk-docs ❌ Failed (Inspect) Sep 28, 2023 1:24pm
job-launcher-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 1:24pm
job-launcher-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 1:24pm

@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-server September 19, 2023 08:54 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-client September 19, 2023 08:55 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle September 19, 2023 08:56 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-reputation-oracle September 19, 2023 08:57 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-recording-oracle September 19, 2023 08:58 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle-server September 19, 2023 09:00 Inactive
Copy link
Collaborator

@leric7 leric7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update SDK doc on GitBook. In addition, we have /examples directory, where we can write down some examples how to use this module. Would be nice if we can have that one as well.

@simulacrum6
Copy link
Contributor Author

gitbook is ready to review as well.

@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle September 28, 2023 12:55 Inactive
@simulacrum6 simulacrum6 merged commit 08f46ea into develop Sep 28, 2023
10 of 21 checks passed
@simulacrum6 simulacrum6 deleted the feat/agreement/usability-updates branch September 28, 2023 12:59
@vercel vercel bot temporarily deployed to Preview – fortune-reputation-oracle September 28, 2023 13:01 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-server September 28, 2023 13:07 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-recording-oracle September 28, 2023 13:10 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-job-launcher-client September 28, 2023 13:16 Inactive
@vercel vercel bot temporarily deployed to Preview – fortune-exchange-oracle-server September 28, 2023 13:19 Inactive
@vercel vercel bot temporarily deployed to Preview – human-protocol-typescript-sdk-docs September 28, 2023 13:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants