This repository has been archived by the owner on Mar 30, 2018. It is now read-only.
Support for optionally configuring phpunit executable #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… path of phpunit executable
Issue154 first working draft of feature to optionally define name and…
daniel-mueller
changed the title
|
Apologies for the delay in responding. I'll be reviewing over the weekend, and will look at merging. |
theofidry
approved these changes
Apr 19, 2017
padraic
approved these changes
Apr 19, 2017
This was referenced May 13, 2017
tabbabi
pushed a commit
to tabbabi/humbug
that referenced
this pull request
Aug 4, 2017
tabbabi
pushed a commit
to tabbabi/humbug
that referenced
this pull request
Aug 4, 2017
Update README.md markdown fix Update README.md Add migration notice & update clone URL Update Travis CI and Scrutinizer badges in readme Apply fixes from StyleCI Run Travis builds for all branches Unify version displaying format Add a download counter to the readme (humbug#222) Make Behat tests up and running (humbug#224) Forces humbug to use the phpunit downloaded using Composer. Handle mocking objects for both PHPUnit 4 and 5 (humbug#226) Support for optionally configuring phpunit executable (humbug#155) Change PHAR compression from bz2 to gzip (humbug#205) Allow to be run with phpdbg (humbug#184) Remove white spaces Improve Travis matrix (humbug#207) Support adding env variables; by default use this to disable Symfony deprecation notices. Fixes @42
tabbabi
pushed a commit
to tabbabi/humbug
that referenced
this pull request
Aug 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to implement the feature requested by the user domnikl and me in Issue #154.
Behaviour of the application remains unchanged as long as the user doesn't include the location of a phpunit.phar in the configfile. If he does, path and name of the provided executable will be passed to the ExecutableFinder.
{ "source": { "directories": [ "src" ] }, ... "phpunit": { "phar": "/absolute/path/to/phpunit-4.8.3.phar" } }If this pull request somehow doesn't measure up to your expectations for a proper PR or you don't want to implement the feature I would be glad to hear from you.