Skip to content
This repository has been archived by the owner on Mar 30, 2018. It is now read-only.

Allow to be run with phpdbg #184

Merged
merged 2 commits into from
Apr 20, 2017
Merged

Allow to be run with phpdbg #184

merged 2 commits into from
Apr 20, 2017

Conversation

bcremer
Copy link
Contributor

@bcremer bcremer commented Aug 8, 2016 •
edited
Loading

Fix for #178

So far it runs fine for ./bin/humbug as well for humburg.phar.

@bcremer bcremer changed the title Allow to be run wiht phpdbg Allow to be run with phpdbg Aug 8, 2016
@mateuszsip
Copy link

Is it scheduled for the next release?
I would love to see that.

@kornrunner
Copy link

Would love to see this merged, phpdbg is so much faster than xdebug for code coverage (which is the current use case). Thanks!

@kelunik kelunik mentioned this pull request Jan 6, 2017
Closed
@keradus
Copy link

keradus commented Feb 6, 2017 •
edited
Loading

any news here ? :)

BTW, example run with this change:

keradus@keradus:~/$ phpdbg -qrr `which humbug`

 _  _            _
| || |_  _ _ __ | |__ _  _ __ _
| __ | || | '  \| '_ \ || / _` |
|_||_|\_,_|_|_|_|_.__/\_,_\__, |
                          |___/ 
Humbug 1.0-dev

@keradus
Copy link

keradus commented Feb 25, 2017

ping @padraic

@theofidry theofidry mentioned this pull request Apr 13, 2017
Closed
@padraic
Copy link
Collaborator

padraic commented Apr 13, 2017

Noting as a critical bug...because ;). That said, is there anything sort of differences in output with this option - I'm just wary given Humbug is very fragile at the CC/PHPUnit borders.

@krakjoe
Copy link

krakjoe commented Apr 13, 2017

Should not be any difference in output.

@theofidry
Copy link
Member

Actually I thinks this should be added to this PR :)

theofidry
theofidry suggested changes Apr 19, 2017
View reviewed changes
Copy link
Member

@theofidry theofidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need a quick mention in the doc

@theofidry theofidry added this to the 1.0.0 milestone Apr 19, 2017
@padraic
Copy link
Collaborator

padraic commented Apr 19, 2017

It could (though I actually meant to comment the issue itself).

@theofidry
Copy link
Member

Well, we could add the note ourselves (we can edit PRs now) so it's not a blocker, I just putted the review as a reminder :)

@bcremer
Copy link
Contributor Author

bcremer commented Apr 20, 2017

Added a section to the README. I'm not a native speaker so feel free to change the wording.

@theofidry theofidry merged commit 1789218 into humbug:master Apr 20, 2017
@keradus
Copy link

keradus commented Apr 20, 2017

wow, magic happen. thanks !

@theofidry
Copy link
Member

Thanks again for that one btw @bcremer, that was personally one of the most missing features for me :P

tabbabi pushed a commit to tabbabi/humbug that referenced this pull request Aug 4, 2017
@bcremer
Allow to be run with phpdbg (humbug#184)
ba4a862
tabbabi pushed a commit to tabbabi/humbug that referenced this pull request Aug 4, 2017
Add config to use custom phpunit.humbug.xml (e.g for symfony project)
8675a96 
Update README.md

markdown fix

Update README.md

Add migration notice & update clone URL

Update Travis CI and Scrutinizer badges in readme

Apply fixes from StyleCI

Run Travis builds for all branches

Unify version displaying format

Add a download counter to the readme (humbug#222)

Make Behat tests up and running (humbug#224)

Forces humbug to use the phpunit downloaded using Composer.

Handle mocking objects for both PHPUnit 4 and 5 (humbug#226)

Support for optionally configuring phpunit executable (humbug#155)

Change PHAR compression from bz2 to gzip (humbug#205)

Allow to be run with phpdbg (humbug#184)

Remove white spaces

Improve Travis matrix (humbug#207)

Support adding env variables; by default use this to disable Symfony deprecation notices.
Fixes @42
tabbabi pushed a commit to tabbabi/humbug that referenced this pull request Aug 4, 2017
@bcremer
Allow to be run with phpdbg (humbug#184)
b32fa22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@padraic padraic padraic approved these changes

@theofidry theofidry theofidry approved these changes

Assignees
No one assigned
Labels
critical bug enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bcremer @mateuszsip @kornrunner @keradus @padraic @krakjoe @theofidry