Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function with multiple namespaces #1061

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

VincentLanglet
Copy link
Contributor

Hi @theofidry, I discovered a bug with the php-scoper.

Before the fix, I get

namespace Acme\Emca {
    if (!function_exists('Acme\Emca\foo')) { function Emca\foo() { return \Humbug\Acme\Emca\foo(...func_get_args()); } }
}

which is crashing.

@theofidry
Copy link
Member

Thank you @VincentLanglet, I'll try to check the CI ASAP to fix it to get this merged

@VincentLanglet
Copy link
Contributor Author

Thank you @VincentLanglet, I'll try to check the CI ASAP to fix it to get this merged

Should I fix the test on this PR @theofidry ? It seems to mainly be CS issues

@theofidry
Copy link
Member

@VincentLanglet the CS yes (I think it's related), but the test failures looks unrelated so in a different MR. Sorry I'm a bit overwhelmed IRL between visists and moving and stuff

@VincentLanglet
Copy link
Contributor Author

@VincentLanglet the CS yes (I think it's related), but the test failures looks unrelated so in a different MR. Sorry I'm a bit overwhelmed IRL between visists and moving and stuff

#1065

@VincentLanglet VincentLanglet mentioned this pull request Sep 2, 2024
Copy link
Member

@theofidry theofidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

tests/AutoReview/GAE2ETest.php Outdated Show resolved Hide resolved
@theofidry theofidry enabled auto-merge (squash) September 2, 2024 13:33
@theofidry theofidry merged commit 79b2b4e into humbug:main Sep 2, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants