Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove humhub\widgets\ModalConfirm for Humhub 1.15 #61

Closed
marc-farre opened this issue Aug 1, 2023 · 2 comments
Closed

Remove humhub\widgets\ModalConfirm for Humhub 1.15 #61

marc-farre opened this issue Aug 1, 2023 · 2 comments
Labels

Comments

@marc-farre
Copy link
Contributor

The module doesn't work on Humhub 1.15 because of humhub\widgets\ModalConfirm in https://github.com/humhub-contrib/linklist/blob/master/views/linklist/index.php

@yurabakhtin
Copy link
Contributor

@luke- I confirm this module doesn't work with v1.15. I have detected this now while working on the humhub/humhub#6486 (comment).

I find the class humhub\widgets\ModalConfirm was removed here https://github.com/humhub/humhub/pull/6172/files#diff-4d0aaf58071b938d674a161ee566cd927eafb368a97f12adfbd4c4a918a49199. I guess @gevorgmansuryan deleted it because it is not easy to find where the class is used when not all modules are installed in system. Probably we should revert the deletion or try to find another solution for this module.

Also I find a place where the use humhub\widgets\ModalConfirm; still exists in core v1.15 - https://github.com/humhub/humhub/blob/develop/protected/humhub/modules/content/widgets/views/containerProfileImageMenu.php#L6

@luke-
Copy link
Contributor

luke- commented Aug 17, 2023

@yurabakhtin Thanks for the investigation.
@gevorgmansuryan will take a look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants