Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global calendar header redesign #447

Closed
marc-farre opened this issue Jan 20, 2024 · 5 comments
Closed

Global calendar header redesign #447

marc-farre opened this issue Jan 20, 2024 · 5 comments

Comments

@marc-farre
Copy link
Contributor

marc-farre commented Jan 20, 2024

The actual header of the global calendar is quite different from the other global pages such as the People and Space pages.

@marc-farre
Copy link
Contributor Author

@luke- #448

I tries to make the code more conventional.

I had to change 2 translations (to remove the <strong> HTML elements):

  • Yii::t('CalendarModule.views_global_index', '<strong>Select</strong> calendars') to Yii::t('CalendarModule.views_global_index', 'Select calendars')
  • Yii::t('CalendarModule.views_global_index', '<strong>Filter</strong> events') to Yii::t('CalendarModule.views_global_index', 'Filter events')

Before:
image

After:
image

@dantefromhell
Copy link
Contributor

I personally prefer the bold text, it gives visual clues to where I can take action on the page.

@marc-farre
Copy link
Contributor Author

I personally prefer the bold text, it gives visual clues to where I can take action on the page.

So in this case we should have bold also on the People page:
image

But the more bold you add, the more confusion on the page you get.
Bold should be on few elements we want to focus on.
This is a filter, so it should not be too proeminent.

And what I removed is the <bold> tag for the first word of the text, but even in the old version it was all bold with CSS, so this tag is useless anyway. And you can always add bold with the theme.

@marc-farre
Copy link
Contributor Author

We have the same page style on the Spaces page:
image

The title of the page (which was missing) and small filter labels.

@dantefromhell
Copy link
Contributor

Bold should be on few elements we want to focus on.
This is a filter, so it should not be too proeminent.
I very much agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants