Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar css local and not responsive, md10/md2 too wide/shallow #53

Closed
ghost opened this issue Mar 28, 2017 · 2 comments
Closed

Calendar css local and not responsive, md10/md2 too wide/shallow #53

ghost opened this issue Mar 28, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Mar 28, 2017

UPDATE: see #55

First, the calendar uses a local css that is not compatible (enough) with the humhub theme (see pictures; e.g. fontsize) further more, it does not work on mobile.

Second, imho the right md-2 columns is too shallow. Changing it to md-8 / md-4 in the debugger makes it a lot more attractive. See pics.

I'd like to see that the css is not local (custom changes will be overwritten in case of an update) and respects at least the theme's font settings.

I've chosen to testdrive HumHub apart from many other social media platforms, for reason that
humhub looks very good on mobile devices - this module breaks the main design and i need to switch it off for our site and that's a pity...

Just my five cents...

Martin

Looks chaotic on mobile:
Looks chaotic on mobile

Too shallow right column:
Too shallow right column

Smaller font (12px) and md-8 / md-4 division looks better:
Smaller font and md-8 / md-4 division looks better

@ghost
Copy link
Author

ghost commented Mar 28, 2017

Changing the HTML in such a way that the middle column becomes a TD on it's own TR, at the top, solves all problems on mobile.

Original code:

<tbody>
<tr>
  		<td class="fc-header-left">
			<span class="fc-button fc-button-prev fc-state-default fc-corner-left" unselectable="on"><span class="fc-icon fc-icon-left-single-arrow"></span></span><span class="fc-button fc-button-next fc-state-default fc-corner-right" unselectable="on"><span class="fc-icon fc-icon-right-single-arrow"></span></span><span class="fc-header-space"></span><span class="fc-button fc-button-today fc-state-default fc-corner-left fc-corner-right fc-state-disabled" unselectable="on">Vandaag</span>
		</td>
  		<td class="fc-header-center">
			<span class="fc-header-title"><h2>maart 2017</h2></span>
		</td>
		<td class="fc-header-right">
			<span class="fc-button fc-button-month fc-state-default fc-corner-left fc-state-active" unselectable="on">Maand</span><span class="fc-button fc-button-agendaWeek fc-state-default" unselectable="on">Week</span><span class="fc-button fc-button-agendaDay fc-state-default fc-corner-right" unselectable="on">Dag</span>
		</td>
	</tr>
</tbody>

Picture (original code):
schermafbeelding 2017-03-28 om 16 42 45

My alternative:

<tbody>
	<tr>
  		<td colspan="3" class="fc-header-center">
			<span class="fc-header-title"><h2>maart 2017</h2></span>
		</td>
  </tr> <tr>
  		<td class="fc-header-left">
			<span class="fc-button fc-button-prev fc-state-default fc-corner-left" unselectable="on"><span class="fc-icon fc-icon-left-single-arrow"></span></span><span class="fc-button fc-button-next fc-state-default fc-corner-right" unselectable="on"><span class="fc-icon fc-icon-right-single-arrow"></span></span><span class="fc-header-space"></span><span class="fc-button fc-button-today fc-state-default fc-corner-left fc-corner-right fc-state-disabled" unselectable="on">Vandaag</span>
		</td>
		<td class="fc-header-right" colspan="2">
			<span class="fc-button fc-button-month fc-state-default fc-corner-left fc-state-active" unselectable="on">Maand</span><span class="fc-button fc-button-agendaWeek fc-state-default" unselectable="on">Week</span><span class="fc-button fc-button-agendaDay fc-state-default fc-corner-right" unselectable="on">Dag</span>
		</td>
	</tr>
</tbody>

Picture (alternative code):
schermafbeelding 2017-03-28 om 16 57 18

@ghost
Copy link
Author

ghost commented Apr 8, 2017

see #55

@ghost ghost closed this as completed Apr 8, 2017
kristianlm pushed a commit to Societec/humhub-modules-calendar that referenced this issue Dec 4, 2017
calcard: Sidebar button and text sizing
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants