-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wall Stream Layout Migration #71 #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good for me. Just a few little things with the create form.
widgets/views/form.php
Outdated
@@ -11,9 +11,16 @@ | |||
|
|||
?> | |||
|
|||
<div class="contentForm_options" data-content-component="polls.Poll" style="margin-bottom:10px;margin-top:0"> | |||
<?= Html::activeTextInput($model,'question', [ | |||
'placeholder' => Yii::t('PollsModule.widgets_views_pollForm', 'Short question...'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@yurabakhtin could you change the richtext layout to |
@orangiene Thanks for the variants! I don't want to change too much in this stage and also in comparison to the current design. @yurabakhtin As first step, can you please try following points:
|
@luke- Please check: |
Looks nice, only the margin between questions/description/answers is a bit to high. Maybe use |
@buddh4 I tested the
If we will use |
@yurabakhtin So the last screenshot is the current state? I think the margin and labels look fine in this one. |
Issues: #71 and humhub/tasks#30