Refactor naming of k8s resources created for a HumioCluster. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2020
jswoods
approved these changes
Jun 11, 2020
This fixes the problems with resource name conflicts when handling multiple HumioCluster resources in the same namespace.
SaaldjorMike
force-pushed
the
mike/refactor_k8s_resource_naming
branch
from
e0da2c9
to
256b839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves us one step closer to closing #92
This fixes the problems with resource name conflicts when handling
multiple HumioCluster resources in the same namespace.
This breaks the
crccluster things for now, because we cannot pre-populate the service account names in theusersproperty in theSecurityContextConstraintresource, because service accounts are now named based on the CR names. I'm thinking we should just merge this anyway because #92 already contains a step to fix the SCC issues. Let me know if you think the SCC changes needs to be done in this PR, then I'll update it, if not, then I will take a look at this in a followup PR.