Install SCC on Helm chart installation and add/remove service accounts from it as needed. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…s from it as needed.
SaaldjorMike
force-pushed
the
mike/update_scc
branch
from
cfeb948
to
bed4a68
Compare
3 tasks
jswoods
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@schofield @jswoods Please note the comment I added here: https://github.com/humio/humio-operator/pull/99/files#diff-ce7c48c375529121a664eed29178b5a3R154-R158
Let me know if you think we should move to finalizers right away, or if this is sufficient for the time being.